Update OpenAPI spec (5164ba2) - #148
Conversation
Greptile SummaryThe PR synchronizes the canonical OpenAPI specification to upstream revision
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking recommendation to derive the new collection items from the canonical connected-account schema. The new response field is coherently documented, but its inline item definition already differs from the reusable resource schema and can drift further as the contract evolves. Files Needing Attention: spec/open-api-spec.yaml Important Files Changed
Prompt To Fix All With AI### Issue 1
spec/open-api-spec.yaml:43261-43263
**Duplicated connected-account schema**
The new collection repeats the connected-account resource inline, and its required fields already differ from the reusable `ConnectedAccount` schema. Maintaining two definitions creates incompatible generated models and requires future resource changes to be duplicated manually.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Update OpenAPI spec from workos/workos@5..." | Re-trigger Greptile |
| items: | ||
| type: object | ||
| properties: |
There was a problem hiding this comment.
Duplicated connected-account schema
The new collection repeats the connected-account resource inline, and its required fields already differ from the reusable ConnectedAccount schema. Maintaining two definitions creates incompatible generated models and requires future resource changes to be duplicated manually.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: spec/open-api-spec.yaml
Line: 43261-43263
Comment:
**Duplicated connected-account schema**
The new collection repeats the connected-account resource inline, and its required fields already differ from the reusable `ConnectedAccount` schema. Maintaining two definitions creates incompatible generated models and requires future resource changes to be duplicated manually.
**Knowledge Base Used:**
- [OpenAPI service contract](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/openapi-spec/-/docs/openapi-contract.md)
- [API resource surface](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/openapi-spec/-/docs/api-resource-surface.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
SDK compatibility report
Changes by domain
|
| Method | Changes | Languages |
|---|---|---|
AdminPortal.generateLink |
organization moved 0→2; returnUrl moved 1→0; successUrl moved 2→1 |
ios |
AuditLogs
Parameter changes (2)
| Method | Changes | Languages |
|---|---|---|
AuditLogs.createSchema |
targets moved 1→2; actor moved 2→1 |
ios |
Authorization
Parameter changes (32)
| Method | Changes | Languages |
|---|---|---|
Authorization.createOrganizationRole |
name moved 1→2; slug moved 2→1 |
ios |
Authorization.createResource |
resourceTypeSlug moved 2→3; organizationId moved 3→4; description moved 4→2 |
ios |
Authorization.listMembershipsForResource |
permissionSlug moved 1→5; before moved 2→1; after moved 3→2; limit moved 4→3; order moved 5→4 |
ios |
Authorization.listMembershipsForResourceAutoPaging |
permissionSlug moved 1→4; before moved 2→1; limit moved 3→2; order moved 4→3 |
ios |
Authorization.listMembershipsForResourceByExternalId |
permissionSlug moved 3→7; before moved 4→3; after moved 5→4; limit moved 6→5; order moved 7→6 |
ios |
Authorization.listMembershipsForResourceByExternalIdAutoPaging |
permissionSlug moved 3→6; before moved 4→3; limit moved 5→4; order moved 6→5 |
ios |
Authorization.listResourcesForMembership |
permissionSlug moved 1→5; before moved 2→1; after moved 3→2; limit moved 4→3; order moved 5→4 |
ios |
Authorization.listResourcesForMembershipAutoPaging |
permissionSlug moved 1→4; before moved 2→1; limit moved 3→2; order moved 4→3 |
ios |
CreateDataIntegrationAuthMethods
1 enum, 3 enum values removed
| Symbol | Kind | Languages |
|---|---|---|
CreateDataIntegrationAuthMethods |
enum | dotnet, php |
CreateDataIntegrationAuthMethods.ApiKey |
enum value | dotnet, php |
CreateDataIntegrationAuthMethods.OAuth |
enum value | dotnet, php |
CreateDataIntegrationAuthMethods.Unknown |
enum value | dotnet |
Events
Parameter changes (9)
| Method | Changes | Languages |
|---|---|---|
Events.list |
events moved 0→4; before moved 1→0; after moved 2→1; limit moved 3→2; order moved 4→3 |
ios |
Events.listAutoPaging |
events moved 0→3; before moved 1→0; limit moved 2→1; order moved 3→2 |
ios |
Pipes
Parameter changes (5)
| Method | Changes | Languages |
|---|---|---|
Pipes.updateDataIntegrationApiKey |
secret moved 2→3; organizationId moved 3→2 |
ios |
Pipes.updateDataIntegrationClientCredentials |
clientId moved 2→3; clientSecret moved 3→4; organizationId moved 4→2 |
ios |
SessionCreatedDataStatus
1 enum, 4 enum values removed
| Symbol | Kind | Languages |
|---|---|---|
SessionCreatedDataStatus |
enum | dotnet |
SessionCreatedDataStatus.Active |
enum value | dotnet |
SessionCreatedDataStatus.Expired |
enum value | dotnet |
SessionCreatedDataStatus.Revoked |
enum value | dotnet |
SessionCreatedDataStatus.Unknown |
enum value | dotnet |
SSO
Parameter changes (5)
| Method | Changes | Languages |
|---|---|---|
SSO.getAuthorizationUrl |
redirectUri moved 0→4; providerScopes moved 1→0; providerQueryParams moved 2→1; domain moved 3→2; provider moved 4→3 |
ios |
UserManagement
Parameter changes (15)
| Method | Changes | Languages |
|---|---|---|
UserManagement.getAuthorizationUrl |
redirectUri moved 0→14; codeChallengeMethod moved 1→0; codeChallenge moved 2→1; domainHint moved 3→2; connectionId moved 4→3; providerQueryParams moved 5→4; providerScopes moved 6→5; invitationToken moved 7→6; maxAge moved 8→7; screenHint moved 9→8; loginHint moved 10→9; provider moved 11→10; prompt moved 12→11; state moved 13→12; organizationId moved 14→13 |
ios |
WaitlistUserState
1 enum, 4 enum values removed
| Symbol | Kind | Languages |
|---|---|---|
WaitlistUserState |
enum | dotnet |
WaitlistUserState.Approved |
enum value | dotnet |
WaitlistUserState.Denied |
enum value | dotnet |
WaitlistUserState.Pending |
enum value | dotnet |
WaitlistUserState.Unknown |
enum value | dotnet |
Additive (1)
DataIntegrationsListResponseData
| Change | Languages |
|---|---|
DataIntegrationsListResponseData.ConnectedAccounts added (field) |
dotnet 📄 src/WorkOS.net/Entities/DataIntegrationsListResponseData.cs go 📄 models.go ios 📄 Sources/WorkOS/Models/DataIntegrationsListResponseData.swift kotlin 📄 src/main/kotlin/com/workos/models/DataIntegrationsListResponseData.kt php 📄 lib/Resource/DataIntegrationsListResponseData.php python 📄 src/workos/pipes/models/data_integrations_list_response_data.py ruby 📄 lib/workos/pipes/data_integrations_list_response_data.rb rust 📄 src/models/data_integrations_list_response_data.rs |
🤖 I see new OpenAPI changes beep boop
Automated update from https://github.com/workos/workos/tree/5164ba2bff4ffea4573609550ded71f7b0135837
Source PRs
Changes